Skip to content

Commit

Permalink
chore: Remove WebGL1 shader modules (#2276)
Browse files Browse the repository at this point in the history
  • Loading branch information
ibgreen authored Sep 26, 2024
1 parent 728a13f commit bd27f0b
Show file tree
Hide file tree
Showing 25 changed files with 18 additions and 2,506 deletions.
16 changes: 8 additions & 8 deletions docs/upgrade-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ luma.gl largely follows [SEMVER](https://semver.org) conventions. Breaking chang
v9.2 brings full WebGPU support. Some additional deprecations and breaking changes have been necessary, but apart from the `Texture` -> `AsyncTexture` split, impact on most applications should be minimal.

**Major change: Texture and AsyncTextures**
- `device.createTexture()` no longer accepts `props.mipmaps`: Use `AsyncTexture` or call texture.generateMipmapsWebGL()`
- `device.createTexture()` no longer accepts `props.mipmaps`: Use `AsyncTexture` or call `texture.generateMipmapsWebGL()`
- The `Texture` class has been simplified to the minimum API required for GPU portability. The `AsyncTexture` texture class provides a higher-level API and is recommended for most applications.
- `device.createTexture()` no longer accepts `props.data`: Use `AsyncTexture` or call `texture.setImageData()`
- `device.createTexture()` no longer accepts `props.mipmaps`: Use `AsyncTexture` (or call `texture.generateMipmapsWebGL()`)

**Major change: Removal of WebGL uniform support**
- `Model.setUniformsWebGL()` dropped, use uniform buffer bindings
- `Renderpipeline.setUniformsWebGL()` dropped, use uniform buffer bindings
- The transition from uniforms to uniform buffers is complete, and remaining support for non-buffer uniforms has been removed.
- `core`: `Renderpipeline.setUniformsWebGL()` dropped, use uniform buffer bindings
- `engine`: `Model.setUniformsWebGL()` dropped, use uniform buffer bindings
- `shadertools`: WebGL1 shader modules have been removed, use the new modules uniform buffer-based counterparts.

**Minor changes**
- The shader type system has been refactored, some shader type names have changed. These are typically not used directly by applications.

**Minor changes**
- The shader type system has been refactored, some shader type names have changed. These are typically not used directly by applications.
- `core`: The shader types has been refactored, some shader type names have changed. These are typically not used directly by applications.

## Upgrading to v9.1

Expand Down
17 changes: 0 additions & 17 deletions modules/shadertools/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,20 +89,3 @@ export type {
export type {PBRProjectionProps} from './modules/lighting/pbr-material/pbr-projection';

export {pbrMaterial} from './modules/lighting/pbr-material/pbr-material';

// DEPRECATED - v8 legacy shader modules (non-uniform buffer)

// math libraries
// export {fp64, fp64arithmetic} from './modules-webgl1/math/fp64/fp64';

// projection and lighting
export {geometry as geometry1} from './modules-webgl1/geometry/geometry';
export {project as project1} from './modules-webgl1/project/project';

export {lights as lights1} from './modules-webgl1/lighting/lights/lights';
export {dirlight as dirlight1} from './modules-webgl1/lighting/dirlight/dirlight';
export {
gouraudLighting,
phongLighting
} from './modules-webgl1/lighting/phong-lighting/phong-lighting';
export {pbr} from './modules-webgl1/lighting/pbr/pbr';
41 changes: 0 additions & 41 deletions modules/shadertools/src/modules-webgl1/geometry/geometry.ts

This file was deleted.

This file was deleted.

This file was deleted.

143 changes: 0 additions & 143 deletions modules/shadertools/src/modules-webgl1/lighting/lights/lights.ts

This file was deleted.

12 changes: 0 additions & 12 deletions modules/shadertools/src/modules-webgl1/lighting/pbr/README.md

This file was deleted.

Loading

0 comments on commit bd27f0b

Please sign in to comment.