add support HTML5-History-API polyfill

[devote]

No description provided.

[nowhereman]

Really useful pull request, it adds old browsers(IEs) support with only one new line of code !
👍

[netpoetica]

So by merging this pull request in, you simply load in pagesjs + history API polyfill and pagejs can officially support IE8 and 9? It would be useful to have some clarification and potentially add some documentation to this pull request about what the end user will need to do in order to have x-browser code operational without reigning in a new abundance of issues

Also +1 this is awesome

[A]

yep, I think the PR is very good, but I need some more time to plan next release. I favorited the PR for merge it some time later :)

[netpoetica]

Heard, let's not wait too long :) I had to abandon usage of pagejs for Sammyjs instead in order to support IE8. Looking forward to getting back to Pagejs as it is much less opinionated and invasive

[devote]

@netpoetica

How to use a HTML5-History-API Polyfill together with router (OPTIONAL):

Before calling page.base() use: history.redirect([prefixType], [basepath]) - Translation link if required.

• prefixTyle: [string|null] - Substitute the string after the anchor (#) by default "/".
• basepath: [string|null] - Set the base path. See page.base() by default "/". (Note: slash after pathname required)

[A]

@devote mb add this guide to readme? Can you?

[jonathanong]

we need to fix the test system so that the tests pass first...

[devote]

Add a first line?

var window = typeof window !== "undefined" ? window : this;

[jonathanong]

well it's weird because in node, this is actually module or exports, forget which. we want to check both window and global. _.

thinking of just switching over to phantomjs since it's an actual browser environment

[devote]

Any ideas?

[devote]

Hmmm ... Again, not passed

[devote]

Was successful test earlier? He stumbles on all that is possible.

[devote]

Tests did not pass. And as I understand it, they never pass.

[netpoetica]

It's hacky but you can also use mocha-browser https://github.com/lepture/mocha-browser that might be a quick solution to get tests passing w/ a browser environment

[alanning]

Not sure if this is what is causing the failed build but we've had similiar issues with window vs global context with code that can run in both the browser and nodejs. This is what worked for us:

;(function (context) {

   // ... code that sticks something on the global context ...
   // ex. 
   // context.MyGlobalClass

})(typeof global === 'undefined' ? window : global);

Important part is to default to global because it seems in nodejs there is a window object supplied but it is not the same as the global context.

[devote]

0 passing (375ms)
  1 failing
  1)  "before all" hook:
     TypeError: Object #<Object> has no method 'addEventListener'
      at Function.page.start (/home/travis/build/visionmedia/page.js/index.js:121:41)
      at page (/home/travis/build/visionmedia/page.js/index.js:80:12)

These errors are quite different https://travis-ci.org/visionmedia/page.js/builds/29408064

[jonathanong]

oh dude your code was fine before. it's a matter of fixing the test system, not your tests.

[devote]

... your code was fine before.

You mean the very first commit?

[andyburke]

what happened with this?

[A]

I fixed tests