Support IE8+ via HTML5-History-API polyfill #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes required: - bubbled click events have to bind to the body, not window - use attachEvent when addEventLister is not defined - event object can be different (e.srcElement, e.which, preventing default). - el.location is different
Changes from @devote. We need to look at `history.location` when it exists (for polyfilled browsers, as `document.location` will included a hash.
|
This would be great! |
|
Any updates? |
Closed
|
Any objections to merging this from anyone? @shuvalov-anton |
|
@nwmcsween I have no objections. Let's go for it |
|
Hoo yeah, lets do it! |
|
So?.. |
|
I would love for this to be pulled in! |
|
Please, add this ! |
|
+1 also would love to see some documentation about it, How to use Pagejs in IE8 |
|
sorry for the delayed response. closing in favor of #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch gets page.js working when polyfilled with @devote's history polyfill in IE8 + 9. Solves (more or less) #5.
The tests don't even begin to run in IE, but passes elsewhere, and it passes all my tests on my Meteor Router. See tmeasday/meteor-router#33 for more information. Haven't had much of a play outside of that context, but my understanding is that it works.