-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hidden edge bug #68
Hidden edge bug #68
Conversation
Fixed a formatting issue that caused yarn format:check to fail (I don't actually understand what the problem was, something about white space, maybe?) |
thanks for the contribution @DarylMcCullough! I hope to test this and get it in sometime over the upcoming July 4th holiday. stay tuned. |
ok, testing this out locally at http://127.0.0.1:8080/test/hidden_edge_test.html here is what I see when I add |
and here's the fix, testing locally on @DarylMcCullough's branch. works beautifully 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
💌 Thanks @DarylMcCullough for your contribution! |
Fixes issue #67 "Network - does updating an edge cause it to reset automatically in Hierarchical view".
There is an example of the buggy behavior in test/hidden_edge_test.html. To see the bug:
The only change is to the file Edge.js in lib/network/modules/components. Rebuild using "yarn" and "yarn build" and then retry the example hidden_edge_test.html