Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden edge bug #68

Merged
merged 3 commits into from
Jul 18, 2019
Merged

Conversation

DarylMcCullough
Copy link
Contributor

Fixes issue #67 "Network - does updating an edge cause it to reset automatically in Hierarchical view".

There is an example of the buggy behavior in test/hidden_edge_test.html. To see the bug:

  • Click on node 3.
  • Drag it to the right.
  • Release the mouse.
  • Then hover over node 3 (or any other node or edge).
  • The graph will reset (it shouldn't).

The only change is to the file Edge.js in lib/network/modules/components. Rebuild using "yarn" and "yarn build" and then retry the example hidden_edge_test.html

@DarylMcCullough
Copy link
Contributor Author

Fixed a formatting issue that caused yarn format:check to fail (I don't actually understand what the problem was, something about white space, maybe?)

@micahstubbs
Copy link
Member

thanks for the contribution @DarylMcCullough! I hope to test this and get it in sometime over the upcoming July 4th holiday. stay tuned.

@micahstubbs
Copy link
Member

ok, testing this out locally at http://127.0.0.1:8080/test/hidden_edge_test.html

here is what I see when I add hidden_edge_test.html to the master branch. I can reproduce the bug. Thanks @DarylMcCullough for the test and the nice instructions to reproduce the bug!

visjs-67-hidden-edge-bug

@micahstubbs
Copy link
Member

and here's the fix, testing locally on @DarylMcCullough's branch. works beautifully 👍

visjs-network-67-hidden-edge-fix

Copy link
Member

@micahstubbs micahstubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mojoaxel
Copy link

💌 Thanks @DarylMcCullough for your contribution!
This pull-request has been merge into visjs/vis-network#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants