visjs-network#68: hidden edge bug #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
use |
yotamberk
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an original contribution from @DarylMcCullough: visjs-community/visjs-network#68
part of #7
Fixes issue #67 "Network - does updating an edge cause it to reset automatically in Hierarchical view".
There is an example of the buggy behavior in test/hidden_edge_test.html. To see the bug:
Click on node 3.
Drag it to the right.
Release the mouse.
Then hover over node 3 (or any other node or edge).
The graph will reset (it shouldn't).
The only change is to the file Edge.js in lib/network/modules/components. Rebuild using "yarn" and "yarn build" and then retry the example hidden_edge_test.html