Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert "feat: show warning to discourage putting process/global to define option (#14447)" #14827

Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: revert "feat: show warning to discourage putting process/global to define option (#14447)" #14827

merged 1 commit into from
Oct 31, 2023

Conversation

sapphi-red
Copy link
Member

Description

This reverts commit 83a56f7, PR #14447.

This is no longer needed as #11151 is merged.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Oct 31, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Oct 31, 2023
@stackblitz StackBlitz
Copy link

stackblitz bot commented Oct 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev enabled auto-merge (squash) October 31, 2023 15:31
@patak-dev patak-dev merged commit 0426910 into vitejs:main Oct 31, 2023
9 of 10 checks passed
@sapphi-red sapphi-red deleted the chore/revert-14447 branch October 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @patak-dev @bluwy