Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show warning to discourage putting process/global to define option #14447

Merged

Conversation

sapphi-red
Copy link
Member

Description

I've been seen many people doing define: { global: 'window' } and breaking their apps.
Ideally it'd be better to improve how define works, but I think having a warning until that's implemented is nice.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 22, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red changed the title feat: show warning to discorage putting process/global to define option feat: show warning to discourage putting process/global to define option Sep 26, 2023
Co-authored-by: patak <matias.capeletto@gmail.com>
@patak-dev patak-dev merged commit 83a56f7 into vitejs:main Sep 26, 2023
9 checks passed
@sapphi-red sapphi-red deleted the feat/show-warning-about-define-global branch October 17, 2023 15:51
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Oct 31, 2023
patak-dev pushed a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants