fix: fsp.rm removing files does not take effect

[btea]

Description

When I execute pnpm dev --debug to start the project, a cache file will be generated in the .vite folder, but when I type q in the terminal to exit the project, the terminal will output information about removing the cache, but the corresponding cache files are not deleted.

I tried to use fs.rmSync to replace fsp.rm and the corresponding cache file could be successfully deleted.

Additional context

I am not sure whether it is related to the operating environment. The above problems were encountered and solved in my local Windows environment, and the corresponding node version is v18.16.1.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines, especially the Pull Request Guidelines.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Update the corresponding documentation if needed.
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[patak-dev]

We're using the same fsp.rm pattern in other places in the code. Maybe we should have a new utility that uses fs.rmSync in Windows in all these places, and keep fsp.rm in the rest of the systems until we get a report. @sapphi-red did you experience this issue in Windows too?

[btea]

I also noticed that the old cache was being removed on every launch.

vite/packages/vite/src/node/optimizer/index.ts

Lines 382 to 384 in b20d542

	// Start with a fresh cache
	debug?.(colors.green(`removing old cache dir ${depsCacheDir}`))
	await fsp.rm(depsCacheDir, { recursive: true, force: true })

The value of depsCacheDir obtained here is xxx/node_modules/.vite/deps, but the folder name format of the generated cache file is xxx/node_modules/.vite/deps_temp_xxx, so the removal operation here seems useless. 🤔

[sapphi-red]

I tested out with both Windows and WSL and it did happen. I guess it's not related to OS.

I think this happens because we call process.exit here.

vite/packages/vite/src/node/shortcuts.ts

Line 155 in b20d542

process.exit()

process.exit doesn't wait for async tasks.

[btea]

Do you think we should differentiate the processing according to different systems or should we replace fsp.rm with fs.rmSync uniformly?

[bluwy]

I can also repro this on macos. I think it's fine to update this single line to use rmSync. We can add a comment that it's needed for cleanup during exit.