Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the MySQL version used by our Docker images #12054

Merged
merged 9 commits into from
Feb 2, 2023
Merged

Update the MySQL version used by our Docker images #12054

merged 9 commits into from
Feb 2, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Jan 9, 2023 •
edited
Loading

Description

This PR upgrades the default MySQL version used by the vitess/lite:latest and vitess/lite:mysql80 images.

  • vitess/lite:latest: 5.7 -> 8.0.31
  • vitess/lite:mysql80: 8.0.23 -> 8.0.31

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@frouioui
Change default MySQL version of lite and base to mysql80 instead of m…
7049b81 
…ysql57

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 9, 2023 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI Release Blocker: release-19.0 This item blocks the release on branch release-19.0 labels Jan 9, 2023
@frouioui
Bump MySQL version to 8.0.31 in install_dependencies.sh
4ad8b37 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into update-docker-image
b5f30e9 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Merge remote-tracking branch 'origin/main' into update-docker-image
556a83d 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
addition of label to the mysql80 image
fcbf412 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@harshit-gangal harshit-gangal mentioned this pull request Jan 30, 2023
Merged
3 tasks
deepthi
deepthi reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes mostly look good.
I'm assuming this is still draft because of a dependency with changes to vitess-operator.

t/main.go Outdated Show resolved Hide resolved
examples/operator/302_new_shards_new_images.yaml Outdated Show resolved Hide resolved
docker/lite/Dockerfile.mysql80 Outdated Show resolved Hide resolved
docker/base/Dockerfile Outdated Show resolved Hide resolved
docker/base/Dockerfile.percona57
@@ -1,3 +1,17 @@
# Copyright 2023 The Vitess Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuptaManan100 GuptaManan100 mentioned this pull request Jan 31, 2023
Closed
35 tasks
@frouioui
Merge remote-tracking branch 'origin/main' into update-docker-image
0b1191a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
apply review suggestions
f2cee63 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Feb 2, 2023
@frouioui
bring back mysql80 label
05c4034 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
add release summary
6954608 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Feb 2, 2023
@frouioui frouioui marked this pull request as ready for review February 2, 2023 15:32
mattlord
mattlord approved these changes Feb 2, 2023
View reviewed changes
doc/releasenotes/16_0_0_summary.md
@@ -56,6 +56,10 @@ The flag is available in these components:

### Breaking Changes

#### Default MySQL version on Docker

The default MySQL version use by our `vitess/lite:latest` image is going from `5.7` to `8.0`. Additionally, the default version of the `vitess/lite:mysql80` image goes from `8.0.23` to `8.0.31`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL version used and the default patch version of the... we can make touch-ups like that as part of the release process though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up PR: #12222

@frouioui frouioui merged commit f139edd into vitessio:main Feb 2, 2023
@frouioui frouioui deleted the update-docker-image branch February 2, 2023 17:57
This was referenced Feb 2, 2023
Merged
Merged
@deepthi deepthi mentioned this pull request Feb 22, 2023
Closed
@GuptaManan100 GuptaManan100 mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi left review comments

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@mattlord mattlord mattlord approved these changes

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@rsajwani rsajwani Awaiting requested review from rsajwani

Assignees
No one assigned
Labels
Component: Build/CI Release Blocker: release-19.0 This item blocks the release on branch release-19.0 Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the MySQL version used in the Docker lite images
4 participants
@frouioui @deepthi @mattlord @GuptaManan100