Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert default MySQL 80 version to 8.0.30 #12252

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Revert default MySQL 80 version to 8.0.30 #12252

merged 6 commits into from
Feb 8, 2023

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Feb 6, 2023 •
edited
Loading

Description

It was found that MySQL 8.0.31 is not supported by the latest version of xtrabackup leading to invalid upgrade paths from v15.x.x to v16.x.x.

While we wait for percona to release its 8.0.31 version, this PR partially reverts some recent changes made in #12054 and #11989, the new MySQL 80 version that will be used is 8.0.30.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
Revert default MySQL 80 version
bba1ddb 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI Backport to: release-16.0 labels Feb 6, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 6, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 6, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@frouioui frouioui changed the title Revert default MySQL 80 version Revert default MySQL 80 version back to 8.0.23 Feb 6, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 6, 2023
@rsajwani
Copy link
Contributor

rsajwani commented Feb 6, 2023

changes look good to me but the test are failing apparently for some other reason ...

@frouioui
Merge remote-tracking branch 'origin/main' into revert-default-8.0-my…
8741fca 
…sql-image

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui changed the title Revert default MySQL 80 version back to 8.0.23 Revert default MySQL 80 version to 8.0.30 Feb 7, 2023
@frouioui
upgrade mysql80 default to 8.0.30
05b1771 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Add release notes regarding MySQL upgrade path in the vitess-operator
242438c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
GuptaManan100
GuptaManan100 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM

@frouioui
Merge remote-tracking branch 'origin/main' into revert-default-8.0-my…
d67b5ee 
…sql-image

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Remove unwanted upgrade path step
0f1990a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit c7605a1 into vitessio:main Feb 8, 2023
@frouioui frouioui deleted the revert-default-8.0-mysql-image branch February 8, 2023 11:30
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 8, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

frouioui added a commit to planetscale/vitess that referenced this pull request Feb 8, 2023
@frouioui
Revert default MySQL 80 version to 8.0.30 (vitessio#12252)
fd7f13b 
* Revert default MySQL 80 version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* upgrade mysql80 default to 8.0.30

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Add release notes regarding MySQL upgrade path in the vitess-operator

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove unwanted upgrade path step

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui mentioned this pull request Feb 8, 2023
Merged
3 tasks
frouioui added a commit that referenced this pull request Feb 8, 2023
@frouioui
Revert default MySQL 80 version to 8.0.30 (#12252) (#12273)
e8c258d 
* Revert default MySQL 80 version



* upgrade mysql80 default to 8.0.30



* Add release notes regarding MySQL upgrade path in the vitess-operator



* Remove unwanted upgrade path step



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@rsajwani rsajwani Awaiting requested review from rsajwani

Assignees
No one assigned
Labels
Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frouioui @rsajwani @mattlord @GuptaManan100