-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TableFilter: fix excluded RE listing #12318
Merged
shlomi-noach
merged 1 commit into
vitessio:main
from
planetscale:schema-fix-exclude-res
Feb 14, 2023
Merged
TableFilter: fix excluded RE listing #12318
shlomi-noach
merged 1 commit into
vitessio:main
from
planetscale:schema-fix-exclude-res
Feb 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
requested review from
deepthi,
mattlord and
rsajwani
as code owners
February 12, 2023 13:59
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Feb 12, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
shlomi-noach
added
Type: Bug
Component: TabletManager
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Feb 12, 2023
3 tasks
3 tasks
frouioui
approved these changes
Feb 13, 2023
mattlord
approved these changes
Feb 14, 2023
ignoring the failures of |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #12317, this PR fixes the slice concatenation for
excludeTableREs
. While at it, adding more unit tests to validate expected behavior, and while at it, modernize the unit test file to usetestify
rather than "bare meta" golang tests.Related Issue(s)
Fixes #12317
Checklist
Deployment Notes