Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing onlineddl_vrepl flakiness, and adding more tests #12325

Merged
merged 24 commits into from
Feb 22, 2023
Merged

Fixing onlineddl_vrepl flakiness, and adding more tests #12325

merged 24 commits into from
Feb 22, 2023

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Feb 12, 2023 •
edited
Loading

Description

This PR depends on:

And on top of these:

  • Uses topo-bases throttler
  • Breaks down throttler/PRS test into more distinct parts
  • Adds new --postpone-completion/PRS test
  • Fixes reading of VReplication status (reduces test time by 60sec)

Only makes sense to review once all the above are merged

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
TableFilter: fix excluded RE listing
e8016a9 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
extract GCTableNameExpression
83967ce 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
VReplication: exclude GC tables when reading schema
f4a76e1 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
wrap schema analyzis errors for better tracability
b3d6043 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Refactor LastError as a public struct
670605d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Online DDL: use LastError for retrying vreplication streams
efc8363 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'refactor-last-error' into fix-onlineddl-vrepl-flakiness…
e1fbd0f 
…-prs

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'onlineddl-last-error-vitess-migrations' into fix-online…
fc543fa 
…ddl-vrepl-flakiness-prs

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
refactor UpdateThrottlerTopoConfig
9681ba1 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
onlineddl_vrepl tests:
6463b5d 
- using topo-based throttler config
- break down of throttle-based PRS test
- adding --postpone-completion -based PRS test
- fixing wait for VReplicatoin status

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 12, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 12, 2023 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 12, 2023
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Feb 12, 2023 •
edited
Loading

Weirdly this PR is seeing onlineddl_vrepl_suite failures. I see those in a local dev env. I don't think the failures are related to the changes in the PR. Will continue testing tomorrow.

Example: https://github.com/vitessio/vitess/actions/runs/4157320118/jobs/7192562249

@shlomi-noach
Copy link
Contributor Author

Aha! OK yes, the tests are definitely related to this PR, or rather to #12323 ; described in #12323 (comment)

@shlomi-noach
differentiate between a temrinally failed workflow and one which 'has…
1f615cb 
… error' and can be retried

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
(re)Formalize SQLError in VReplication, add underlying wrap/unwrap fu…
8e58a57 
…nctionality

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach mentioned this pull request Feb 13, 2023
Merged
3 tasks
@shlomi-noach
Merge branch 'sql-error-unwrap-vreplication' into fix-onlineddl-vrepl…
9c22b07 
…-flakiness-prs

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
differentiate between a temrinally failed workflow and one which 'has…
1b2cbf4 
… error' and can be retried

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
wording
517f9cd 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
simplified hasError()
67eb983 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
merge main, resolve conflict
9096e1b 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@frouioui frouioui mentioned this pull request Feb 16, 2023
Closed
51 tasks
rohit-nayak-ps
rohit-nayak-ps approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once dependent PRs are merged, need to rebase and get CI to pass. But otherwise lgtm.

@shlomi-noach
merge main, resolve conflict
ea93b14 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'main' into onlineddl-last-error-vitess-migrations
62833cb 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'main' into onlineddl-last-error-vitess-migrations
ffdd56c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'main' into fix-onlineddl-vrepl-flakiness-prs
edb1e6e 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
merge main, resolve conflict
e4ae682 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
do not unwrap
b761b86 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'main' into fix-onlineddl-vrepl-flakiness-prs
5aff932 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

I'm ignoring Upgrade Downgrade Testing failures.

@shlomi-noach shlomi-noach merged commit 5b393cd into vitessio:main Feb 22, 2023
@shlomi-noach shlomi-noach deleted the fix-onlineddl-vrepl-flakiness-prs branch February 22, 2023 12:59
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 22, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

@shlomi-noach
Copy link
Contributor Author

I'm backporting this manually

@shlomi-noach shlomi-noach mentioned this pull request Feb 22, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

@mattlord mattlord Awaiting requested review from mattlord

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@rsajwani rsajwani Awaiting requested review from rsajwani

Assignees
No one assigned
Labels
Component: Build/CI Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shlomi-noach @frouioui @rohit-nayak-ps @deepthi