Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement LOCATE and friends #15195

Merged
merged 3 commits into from
Feb 12, 2024

evalengine: Simplify logic for collation handling

789bbad
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement LOCATE and friends #15195

evalengine: Simplify logic for collation handling
789bbad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 12, 2024 in 1s

67.36% (+20.06%) compared to eddb39e

View this Pull Request on Codecov

67.36% (+20.06%) compared to eddb39e

Details

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (789bbad) 67.36%.
Report is 135 commits behind head on main.

Files Patch % Lines
go/cmd/vtcombo/cli/main.go 0.00% 17 Missing ⚠️
go/cmd/vttablet/cli/cli.go 0.00% 13 Missing ⚠️
go/cmd/vtgate/cli/cli.go 0.00% 8 Missing ⚠️
go/mysql/collations/charset/eightbit/8bit.go 0.00% 8 Missing ⚠️
go/mysql/conn.go 53.84% 6 Missing ⚠️
go/mysql/capabilities/capability.go 91.48% 4 Missing ⚠️
go/mysql/query.go 77.77% 4 Missing ⚠️
go/cmd/vtadmin/main.go 0.00% 3 Missing ⚠️
go/cmd/vtctl/vtctl.go 0.00% 3 Missing ⚠️
go/event/syslogger/syslogger.go 57.14% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15195       +/-   ##
===========================================
+ Coverage   47.29%   67.36%   +20.06%     
===========================================
  Files        1137     1560      +423     
  Lines      238684   192576    -46108     
===========================================
+ Hits       112895   129733    +16838     
+ Misses     117168    62843    -54325     
+ Partials     8621        0     -8621     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.