Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-tenant MoveTables: allow switching replica/rdonly traffic separately before switching primary traffic #15768

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Apr 21, 2024

Description

As part of #15403 we had assumed it was fine to switch all traffic at the same time. However it turns out there are use cases where we may want to allow switching replica/rdonly and primary traffic separately, similar to other workflows.

This PR adds that support.

Related Issue(s)

#15403

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Apr 21, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 21, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 21, 2024
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsWebsiteDocsUpdate What it says labels Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 8.51064% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 68.41%. Comparing base (5fd70c4) to head (430d2ca).

Files Patch % Lines
go/vt/vtctl/workflow/utils.go 0.00% 44 Missing ⚠️
go/vt/vtctl/workflow/server.go 17.64% 14 Missing ⚠️
go/vt/vtgate/vindexes/vschema.go 31.25% 11 Missing ⚠️
go/vt/vtctl/workflow/switcher_dry_run.go 0.00% 7 Missing ⚠️
go/vt/vtctl/workflow/switcher.go 0.00% 5 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15768      +/-   ##
==========================================
- Coverage   68.43%   68.41%   -0.03%     
==========================================
  Files        1558     1558              
  Lines      196039   196093      +54     
==========================================
- Hits       134161   134155       -6     
- Misses      61878    61938      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only had some very minor comments/nits that you can address as you feel best.

go/test/endtoend/vreplication/helper_test.go Show resolved Hide resolved
go/test/endtoend/vreplication/helper_test.go Show resolved Hide resolved
go/test/endtoend/vreplication/helper_test.go Outdated Show resolved Hide resolved
go/test/endtoend/vreplication/helper_test.go Show resolved Hide resolved
go/vt/vtctl/workflow/server.go Outdated Show resolved Hide resolved
go/vt/vtctl/workflow/server.go Outdated Show resolved Hide resolved
go/vt/vtctl/workflow/switcher_dry_run.go Outdated Show resolved Hide resolved
go/vt/vtctl/workflow/utils.go Outdated Show resolved Hide resolved
go/test/endtoend/vreplication/helper_test.go Show resolved Hide resolved
go/vt/vtctl/workflow/traffic_switcher.go Outdated Show resolved Hide resolved
@deepthi
Copy link
Member

deepthi commented Apr 26, 2024

mattlord's feedback still needs to be addressed. Rest LGTM.

…ng rules

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…ly. Change expected keyspace routing rules.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…ules also for replica/rdonly

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…, so you can't route target keyspace to a specific tenant

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps force-pushed the rohit/multi-tenant-switch-traffic-routing-rule-mods branch from 629d893 to 116a3b4 Compare April 27, 2024 11:04
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps merged commit 1e143c3 into vitessio:main Apr 27, 2024
104 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the rohit/multi-tenant-switch-traffic-routing-rule-mods branch April 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants