Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-tenant MoveTables: allow switching replica/rdonly traffic separately before switching primary traffic #15768

Merged
merged 19 commits into from
Apr 27, 2024
Merged

Multi-tenant MoveTables: allow switching replica/rdonly traffic separately before switching primary traffic #15768

merged 19 commits into from
Apr 27, 2024

Commits on Apr 27, 2024

  1. Modify vtgate route checks to include tablet types for keyspace routi… 

    …ng rules

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a7b9bf7 View commit details
    Browse the repository at this point in the history

  2. Update e2e MultiTenantSimple test to switch reads and writes separate… 

    …ly. Change expected keyspace routing rules.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7427810 View commit details
    Browse the repository at this point in the history

  3. Add switching keyspace reads to switcher interface/implementations 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f8454c4 View commit details
    Browse the repository at this point in the history

  4. Add helpers to get state of current route for a workflow 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    3161ee3 View commit details
    Browse the repository at this point in the history

  5. Implement switch reads for multi-tenant migrations 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ba481c9 View commit details
    Browse the repository at this point in the history

  6. Validate route in e2e test using vexplain. 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    dabc1c2 View commit details
    Browse the repository at this point in the history

  7. Update logic to find correct route for table using keyspace routing r… 

    …ules also for replica/rdonly

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7a6d21e View commit details
    Browse the repository at this point in the history

  8. Update vtctld logic to route and switch separately for replica/rdonly 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ca1c031 View commit details
    Browse the repository at this point in the history

  9. Self-review 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    1ed99f0 View commit details
    Browse the repository at this point in the history

  10. Improve check for reads/writes switched 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a307f55 View commit details
    Browse the repository at this point in the history

  11. Confirm reverse replication works 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    201b838 View commit details
    Browse the repository at this point in the history

  12. Refactor how keyspace routing state is set on building workflow state 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7404c8f View commit details
    Browse the repository at this point in the history

  13. Tiny refactor 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    81257be View commit details
    Browse the repository at this point in the history

  14. Don't route target keyspace since multiple tenants are being migrated… 

    …, so you can't route target keyspace to a specific tenant

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    bb531af View commit details
    Browse the repository at this point in the history

  15. Add rows after complete for concurrent migration test 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    d00e8aa View commit details
    Browse the repository at this point in the history

  16. Address review comment: remove superfluous json specifiers 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    9fa5a63 View commit details
    Browse the repository at this point in the history

  17. Address more review comments 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    3d3eb22 View commit details
    Browse the repository at this point in the history

  18. Fix incorrectly fixed review comment 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    116a3b4 View commit details
    Browse the repository at this point in the history

  19. Fix merge issue 

    Signed-off-by: Rohit Nayak <rohit@planetscale.com>
    @rohit-nayak-ps
    rohit-nayak-ps committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    430d2ca View commit details
    Browse the repository at this point in the history