-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: json encoding on bind variables #16615
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Aug 19, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
json-encoding-fix
branch
from
August 20, 2024 16:18
1da761a
to
5e16eb6
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Aug 21, 2024
harshit-gangal
requested review from
systay,
frouioui and
GuptaManan100
as code owners
August 21, 2024 05:00
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16615 +/- ##
==========================================
+ Coverage 68.77% 68.87% +0.10%
==========================================
Files 1557 1562 +5
Lines 199826 200627 +801
==========================================
+ Hits 137422 138178 +756
- Misses 62404 62449 +45 ☔ View full report in Codecov by Sentry. |
systay
approved these changes
Aug 22, 2024
5 tasks
Closing in favor of #16637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with sending json type as bind variable to vttablet.
Related Issue(s)
INSERT INTO ... SELECT * FROM ...
to copy data between keyspaces #16614Checklist
Deployment Notes