-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Encoding: Use Type_RAW for marshalling json #16637
JSON Encoding: Use Type_RAW for marshalling json #16637
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16637 +/- ##
==========================================
- Coverage 68.98% 68.92% -0.06%
==========================================
Files 1562 1564 +2
Lines 200697 201371 +674
==========================================
+ Hits 138446 138798 +352
- Misses 62251 62573 +322 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…n binlog events instead of Type_JSON, which is now treated as a regular quoted type Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
0509a02
to
6e3247a
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…) (#16681) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
…) (#16682) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
…) (#16680) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Description
This PR cherry-picks commits from #16615, but reverts the changes made in
insert_select.go
to treatType_JSON
differently, but uses all the added tests. #16615 is an attempt to fix the issue #16614 with sending json type as bind variable to vttablet.This PR attempts to fix that issue by not sending the marshalled json objects in vreplication workflows as a newly introduced internal type
Type_RAW
which is encoded as raw bytes. Previously we used to encodeType_JSON
as raw, which is incorrect since we do want to quote json strings. In vreplication workflows, we use json functions like json_object() to specify the json document to preserve precision of large integers.This bug is present since several versions, so we backport to all supported versions.
Marked
Do Not Merge
while waiting for more 👀 on this change.Related Issue(s)
INSERT INTO ... SELECT * FROM ...
to copy data between keyspaces #16614Checklist