-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: use new commands #6052
helm: use new commands #6052
Conversation
LGTM, I will update the docs |
The examples all work for me (with 8GiB for minikube). May I suggest we update the alias to be 'mysql' instead of 'vmysql'. My docs currently assume this - if we use vmysql, then there will be more differences between the two. Unfortunately, the ~/.my.cnf file idea won't work because a script needs to be run. |
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
(Different unit tests failed 3 times due to flakyness, so I used admin overwrite to merge.) |
@rohit-nayak-ps @morgo
The helm examples have been changed to use the new resharding commands.
Note the new README.md file. We don't need to run that many yaml upgrades any more. But I've kept them for now. We can delete them once the newer way of directly issuing "vclient" commands becomes the norm.
@rohit-nayak-ps: Note the different method I use for
MoveTables
that doesn't require the extra steps of copying schema or applying vschema. Those parts are performed byMoveTables
itself. We should change the local example to use the same approach.We'll eventually have to update the cleanup steps once the
DropSources
command is implemented.