Minimal Edits to Bring Helm up to date #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
force-pushed
the
morgo-update-helm-get-started
branch
from
fe05bf1
to
0ffba00
Compare
sougou
approved these changes
Apr 15, 2020
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
morgo
force-pushed
the
morgo-update-helm-get-started
branch
from
ca722fc
to
20493d6
Compare
Current instructions won't work on precompiled binaries. We can remove this in 1-week Signed-off-by: Morgan Tocker <tocker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the minimal edits required for vitessio/vitess#6052
5GiB of memory did not work for me on the resharding exercises, so I had to increase the memory size to 8GiB. I think this is quite limiting for local dev - another step we could try is say "you can try 5, but the resharding exercises require 8".
Some edits have been made to make as many exercises make sense for helm and local without changes.
I have future plans to improve this through a GUI toggle to say which examples to show (Helm or Local). But I think we should try and merge early and then fix it.
Signed-off-by: Morgan Tocker tocker@gmail.com