Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globals do not match with vitest/globals.d.ts #598

Closed
yongholeeme opened this issue Dec 17, 2024 · 0 comments · Fixed by #599
Closed

globals do not match with vitest/globals.d.ts #598

yongholeeme opened this issue Dec 17, 2024 · 0 comments · Fixed by #599

Comments

@yongholeeme
Copy link
Contributor

yongholeeme commented Dec 17, 2024 •
edited
Loading

The globals defined in @vitest/eslint-plugin (source) are not synchronized with the official type definitions in vitest/globals.d.ts (source).

This inconsistency could lead to confusion and potential issues when using ESLint with Vitest. The globals should be aligned between these two official packages.

assertType, expectTypeOf, onTestFailed, and onTestFinished need to be added to globals
yongholeeme added a commit to yongholeeme/eslint-plugin-vitest that referenced this issue Dec 17, 2024
@yongholeeme
feat: add missing globals (vitest-dev#598)
bef2e65
@yongholeeme yongholeeme mentioned this issue Dec 17, 2024
Merged
veritem pushed a commit that referenced this issue Dec 17, 2024
@yongholeeme
feat: add missing globals (#598) (#599)
a0e9641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add missing globals yongholeeme/eslint-plugin-vitest
1 participant
@yongholeeme