Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing globals #599

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: add missing globals #599

merged 1 commit into from
Dec 17, 2024

Conversation

yongholeeme
Copy link
Contributor

@yongholeeme yongholeeme commented Dec 17, 2024 •
edited
Loading

Hello, the globals defined in @vitest/eslint-plugin (source) are not synchronized with the official type definitions in vitest/globals.d.ts (source).

close #598

@yongholeeme yongholeeme changed the title Add missing globals (vitest-dev#598) Add missing globals Dec 17, 2024
@yongholeeme yongholeeme changed the title Add missing globals feat: add missing globals Dec 17, 2024
@yongholeeme yongholeeme mentioned this pull request Dec 17, 2024
Closed
veritem
veritem approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@veritem veritem merged commit a0e9641 into vitest-dev:main Dec 17, 2024
@yongholeeme yongholeeme mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

globals do not match with vitest/globals.d.ts
2 participants
@yongholeeme @veritem