Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add override parameter to all block factories in @comet/blocks-admin #3255

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Add override parameter to all block factories in @comet/blocks-admin #3255

merged 6 commits into from
Jan 30, 2025

Conversation

Reaw
Copy link
Contributor

@Reaw Reaw commented Jan 22, 2025 •
edited
Loading

Description

Acceptance criteria

Further information

@Reaw Reaw changed the title Create blocks overrides Add override parameter to all createBlock factory functions Jan 22, 2025
@Reaw Reaw force-pushed the create-blocks-overrides branch from 24e5ba7 to 41f3010 Compare January 23, 2025 08:42
@Reaw Reaw marked this pull request as ready for review January 23, 2025 08:44
@auto-assign auto-assign bot requested a review from johnnyomair January 23, 2025 08:44
@Reaw Reaw changed the title Add override parameter to all createBlock factory functions Add override parameter to all createBlock factory functions Jan 23, 2025
@Reaw Reaw mentioned this pull request Jan 23, 2025
Open
4 tasks
@Reaw Reaw requested a review from nsams January 27, 2025 09:27
@nsams nsams removed their request for review January 27, 2025 11:24
johnnyomair
johnnyomair reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding it to createImageLinkBlock, createTextLinkBlock etc. as well?

packages/admin/blocks-admin/src/blocks/factories/createBlocksBlock.test.tsx Show resolved Hide resolved
.changeset/polite-chairs-join.md Outdated Show resolved Hide resolved
@Reaw @johnnyomair
Update .changeset/polite-chairs-join.md
1fa6e27 
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@Reaw
Copy link
Contributor Author

Reaw commented Jan 28, 2025 •
edited
Loading

Have you considered adding it to createImageLinkBlock, createTextLinkBlock etc. as well?

I would say we could do that in a follow up PR to keep it relatively small, as the functions you mention are in a different package anyways. what do you think?

Edit: I made it inn this PR #3280

@Reaw Reaw mentioned this pull request Jan 28, 2025
Merged
3 tasks
@Reaw Reaw changed the title Add override parameter to all createBlock factory functions Add override parameter to all blocks-admin factory functions Jan 28, 2025
@Reaw
Copy link
Contributor Author

Reaw commented Jan 29, 2025

@johnnyomair Can we merge this one? :) I will then rebase the next one #3280 and open it

@johnnyomair johnnyomair changed the title Add override parameter to all blocks-admin factory functions Add override parameter to all block factories in @comet/blocks-admin Jan 30, 2025
@johnnyomair johnnyomair merged commit 948e07b into main Jan 30, 2025
11 checks passed
@johnnyomair johnnyomair deleted the create-blocks-overrides branch January 30, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@Reaw Reaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reaw @johnnyomair