Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add override parameter to all block factories in @comet/cms-admin #3280

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Add override parameter to all block factories in @comet/cms-admin #3280

merged 5 commits into from
Feb 5, 2025

Conversation

Reaw
Copy link
Contributor

@Reaw Reaw commented Jan 28, 2025 •
edited
Loading

Description

Add overrides to cms-admin block factories
Depends on #3255

Acceptance criteria

Further information

@Reaw Reaw changed the title Add overrides cms-admin block factories Add overrides to cms-admin block factories Jan 28, 2025
@Reaw Reaw mentioned this pull request Jan 28, 2025
Merged
3 tasks
@Reaw Reaw changed the title Add overrides to cms-admin block factories Add override parameter to all cms-admin factory functions Jan 28, 2025
@Reaw Reaw changed the title Add override parameter to all cms-admin factory functions Add override parameter to all block factories in @comet/cms-admin Feb 3, 2025
@Reaw Reaw force-pushed the block-overrides-cms-admin branch from 7fdb155 to 9458149 Compare February 3, 2025 08:06
@Reaw Reaw marked this pull request as ready for review February 3, 2025 08:10
@auto-assign auto-assign bot requested a review from johnnyomair February 3, 2025 08:10
Reaw and others added 2 commits February 5, 2025 10:09
@Reaw @johnnyomair
Update .changeset/strong-bees-breathe.md
4d1cfa2 
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@Reaw @johnnyomair
Update createLinkBlock override type
6e04b72 
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
@johnnyomair johnnyomair merged commit c71604e into main Feb 5, 2025
11 checks passed
@johnnyomair johnnyomair deleted the block-overrides-cms-admin branch February 5, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@Reaw Reaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reaw @johnnyomair