Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor issues #1632

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix some minor issues #1632

merged 4 commits into from
Nov 29, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Nov 29, 2023

Summary:

This PR:

  • Adds a scroll feature to the Novel View when an item is activated, which is used when a document auto-opens in the editor, like during looped searches.
  • Fixes the editor auto select feature to include apostrophe characters (right single quote and straight apostrophe) when selecting a word as long as there is a alphanumeric character on either side.
  • Some cleanup in Novel View module.

Related Issue(s):

Closes #1555
Closes #1624

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.2 milestone Nov 29, 2023
@vkbo vkbo merged commit 78a75d5 into dev Nov 29, 2023
9 checks passed
@vkbo vkbo deleted the various_fixes branch November 29, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant