Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: change single blank comment to blank line #22016

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

yuyi98
Copy link
Member

@yuyi98 yuyi98 commented Aug 9, 2024

This PR change single blank comment to blank line.

  • Make the codes cleaner.

@spytheman
Copy link
Member

Hm, https://github.com/vlang/v/actions/runs/10315732767/job/28558261008 was interesting...

There seems to be a scanner panic, uncovered by that comment removal 🤔 .

=========================================
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/builtin/builtin.c.v:83: at panic_debug: Backtrace
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/builtin/string.v:1099: by string_substr
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/scanner/scanner.v:1471: by v__scanner__Scanner_decode_u32_escape_single
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/scanner/scanner.v:1357: by v__scanner__Scanner_ident_string
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/scanner/scanner.v:801: by v__scanner__Scanner_text_scan
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/scanner/scanner.v:599: by v__scanner__Scanner_scan_remaining_text
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/scanner/scanner.v:588: by v__scanner__Scanner_scan_all_tokens_in_buffer
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/scanner/scanner.v:152: by v__scanner__new_scanner
examples/2048/2048_fuzz.v:343:15: parser failure: crash, 
/tmp/v_1001/../../../../../../home/runner/work/v/v/vlib/v/parser/parser.v:194: by v__parser__parse_text
/tmp/v_1001/../../../../../../home/runner/work/v/v/cmd/tools/vtest-parser.v:59: by main__main
/tmp/v_1001/../../../../../../tmp/v_1001/vtest-parser.01J4V4R8M3DF9XR5QJ3W0DEW8E.tmp.c:57526: by main

@spytheman
Copy link
Member

The panic is fixed on master, in 793b66d .

@spytheman spytheman merged commit 19f080f into vlang:master Aug 9, 2024
73 checks passed
@yuyi98 yuyi98 deleted the cleanup_empty_comment branch August 9, 2024 12:01
spytheman added a commit to martinskou/v that referenced this pull request Aug 11, 2024
* master:
  flag: add optional value description to string parameters (vlang#22024)
  fmt: fix alignment of struct init fields (vlang#22025)
  cgen: fix selector with interface var (vlang#22006)
  checker: add a deprecation warning for `const ()` groups (an error after 2025-01-01) (vlang#22019)
  v2: fix a notice for `v cmd/v2/v2.v`
  tools: reduce number of os/fs calls done by `v where`; ignore tests/ folders
  tools: make `v where` ignore .git/ folders (they contain binary files); let `-dir .` work recursively, so that `-dir vlib` works
  fmt: cleanup fields alignment (vlang#22018)
  veb: change example description, to avoid repetitive wording (ease debugging of issue#22017)
  all: allow multi return as fn argument (vlang#21991)
  examples: change // to blank line in 2048.v too, after 793b66d
  all: change single blank comment to blank line (vlang#22016)
  scanner: guard against scanner panic, discovered by fuzzing in PR#22016
  time: `d`,`c`,`dd`,`ddd`,`dddd` pattern support for parse_format() (vlang#22003)
  ast, parser, fmt: cleanup fmt of struct fields with empty line (vlang#22014)
  ast, parser, fmt: fix fmt of enum fields with empty line (vlang#22015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants