Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: cleanup fields alignment #22018

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Conversation

yuyi98
Copy link
Member

@yuyi98 yuyi98 commented Aug 10, 2024

This PR cleanup fields alignment.

@spytheman
Copy link
Member

Weird, I do not understand the vsl/vtl errors on the CI 🤔 .

@spytheman
Copy link
Member

spytheman commented Aug 10, 2024

/home/runner/.vmodules/vsl/errors/errors.v:8:1: notice: `[attr]` has been deprecated, use `@[attr]` instead
    6 | }
    7 | 
    8 | [inline]
      | ^

It behaves, as if it is using an older vsl version for some reason 🤔 ... The most recent version on main, does not have that [inline] there, but @[inline] already, since 2221fd 2023-11-19 .

@spytheman
Copy link
Member

It is also not specific to this PR, but affects #22019 too 🤔 .

@spytheman
Copy link
Member

I've pushed a new formatted version of the main branch of vlang/vsl . Hopefully that will fix it, by invalidating a cache somewhere 🤔 .

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit b8435ba into vlang:master Aug 10, 2024
61 checks passed
@yuyi98 yuyi98 deleted the cleanup_fmt_align branch August 10, 2024 13:09
spytheman added a commit to martinskou/v that referenced this pull request Aug 11, 2024
* master:
  flag: add optional value description to string parameters (vlang#22024)
  fmt: fix alignment of struct init fields (vlang#22025)
  cgen: fix selector with interface var (vlang#22006)
  checker: add a deprecation warning for `const ()` groups (an error after 2025-01-01) (vlang#22019)
  v2: fix a notice for `v cmd/v2/v2.v`
  tools: reduce number of os/fs calls done by `v where`; ignore tests/ folders
  tools: make `v where` ignore .git/ folders (they contain binary files); let `-dir .` work recursively, so that `-dir vlib` works
  fmt: cleanup fields alignment (vlang#22018)
  veb: change example description, to avoid repetitive wording (ease debugging of issue#22017)
  all: allow multi return as fn argument (vlang#21991)
  examples: change // to blank line in 2048.v too, after 793b66d
  all: change single blank comment to blank line (vlang#22016)
  scanner: guard against scanner panic, discovered by fuzzing in PR#22016
  time: `d`,`c`,`dd`,`ddd`,`dddd` pattern support for parse_format() (vlang#22003)
  ast, parser, fmt: cleanup fmt of struct fields with empty line (vlang#22014)
  ast, parser, fmt: fix fmt of enum fields with empty line (vlang#22015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants