Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen,checker: fix map generic fn arg passing #22071

Merged
merged 9 commits into from
Aug 20, 2024
Merged

cgen,checker: fix map generic fn arg passing #22071

merged 9 commits into from
Aug 20, 2024

Conversation

felipensp
Copy link
Member

Fix #22035

Delta456
Delta456 reviewed Aug 17, 2024
View reviewed changes
vlib/v/gen/c/fn.v Outdated Show resolved Hide resolved
@felipensp felipensp marked this pull request as ready for review August 19, 2024 20:27
spytheman
spytheman approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit cf0fb83 into vlang:master Aug 20, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delta456 Delta456 Delta456 left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing a map to a generic argument changes a key value from int to an empty string
3 participants
@felipensp @spytheman @Delta456