Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgen,checker: fix map generic fn arg passing #22071

Merged
merged 9 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions vlib/v/checker/fn.v
Original file line number Diff line number Diff line change
Expand Up @@ -1723,7 +1723,6 @@ fn (mut c Checker) resolve_comptime_args(func ast.Fn, node_ ast.CallExpr, concre
if ctyp != ast.void_type {
arg_sym := c.table.final_sym(call_arg.typ)
param_typ_sym := c.table.sym(param_typ)

if param_typ.has_flag(.variadic) {
ctyp = ast.mktyp(ctyp)
comptime_args[k] = ctyp
Expand Down Expand Up @@ -1756,11 +1755,19 @@ fn (mut c Checker) resolve_comptime_args(func ast.Fn, node_ ast.CallExpr, concre
cparam_type_sym := c.table.sym(c.unwrap_generic(ctyp))
if param_typ_sym.kind == .array && cparam_type_sym.info is ast.Array {
comptime_args[k] = cparam_type_sym.info.elem_type
} else if param_typ_sym.kind == .map
} else if param_typ_sym.info is ast.Map
&& cparam_type_sym.info is ast.Map {
comptime_args[k] = cparam_type_sym.info.key_type
comptime_args[k + 1] = cparam_type_sym.info.value_type
k++
key_is_generic := param_typ_sym.info.key_type.has_flag(.generic)
if key_is_generic {
comptime_args[k] = cparam_type_sym.info.key_type
}
if param_typ_sym.info.value_type.has_flag(.generic) {
k2 := if key_is_generic { k + 1 } else { k }
comptime_args[k2] = cparam_type_sym.info.value_type
if key_is_generic {
k++
}
}
felipensp marked this conversation as resolved.
Show resolved Hide resolved
} else {
if node_.args[i].expr.is_auto_deref_var() {
ctyp = ctyp.deref()
Expand Down
18 changes: 14 additions & 4 deletions vlib/v/gen/c/fn.v
Original file line number Diff line number Diff line change
Expand Up @@ -1343,11 +1343,21 @@ fn (mut g Gen) resolve_comptime_args(func ast.Fn, mut node_ ast.CallExpr, concre
cparam_type_sym := g.table.sym(g.unwrap_generic(ctyp))
if param_typ_sym.kind == .array && cparam_type_sym.info is ast.Array {
comptime_args[k] = cparam_type_sym.info.elem_type
} else if param_typ_sym.kind == .map
} else if param_typ_sym.info is ast.Map
&& cparam_type_sym.info is ast.Map {
comptime_args[k] = cparam_type_sym.info.key_type
comptime_args[k + 1] = cparam_type_sym.info.value_type
k++
key_is_generic := param_typ_sym.info.key_type.has_flag(.generic)
println(param_typ_sym)
println(cparam_type_sym)
felipensp marked this conversation as resolved.
Show resolved Hide resolved
if key_is_generic {
comptime_args[k] = cparam_type_sym.info.key_type
}
if param_typ_sym.info.value_type.has_flag(.generic) {
k2 := if key_is_generic { k + 1 } else { k }
comptime_args[k2] = cparam_type_sym.info.value_type
if key_is_generic {
k++
}
}
} else {
if node_.args[i].expr.is_auto_deref_var() {
ctyp = ctyp.deref()
Expand Down
19 changes: 19 additions & 0 deletions vlib/v/tests/comptime_map_part_generic_test.v
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
fn marshal[T](val T) string {
return marshal_map(val)
}

fn marshal_map[T](val map[string]T) string {
return typeof(val).name
}

fn test_main() {
assert marshal({
'a': 1
}) == 'map[string]int'
assert marshal({
'a': true
}) == 'map[string]bool'
assert marshal({
'a': 1.2
}) == 'map[string]f64'
}
Loading