This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Only ship the necessary libs in the gem artifact #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gem artifact is not the ideal place to ship examples, contributing docs, a rake file and various hidden files. This will greatly reduce the size of the installed gem artifact and speed up installs on systems with malware scanners. This drops the compressed gem size from 221k to 47k. Signed-off-by: Tim Smith <tsmith@chef.io>
|
Agreed. I'll take a look at this today. Thanks for your contribution! |
jrgarcia
suggested changes
Dec 18, 2018
rbvmomi.gemspec
Outdated
| @@ -16,7 +16,7 @@ Gem::Specification.new do |spec| | |||
| spec.license = 'MIT' | |||
|
|
|||
| spec.bindir = 'exe' | |||
| spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(/^test\//) } | |||
| spec.files = %w{LICENSE README.md} + Dir.glob("{lib,exec}/**/*") | |||
There was a problem hiding this comment.
I think you meant to put exe rather than exec in there, but that isn't really needed as you'll never require it and it's pulled into the gem through the spec.executables line below. What is needed, however, is the vmodl.db file in the root of the repository. Other than that, I think this looks good.
There was a problem hiding this comment.
Oops. Nice catch. I pushed a few for the right path.
Signed-off-by: Tim Smith <tsmith@chef.io>
jrgarcia
suggested changes
Dec 18, 2018
rbvmomi.gemspec
Outdated
| @@ -16,7 +16,7 @@ Gem::Specification.new do |spec| | |||
| spec.license = 'MIT' | |||
|
|
|||
| spec.bindir = 'exe' | |||
| spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(/^test\//) } | |||
| spec.files = %w{LICENSE README.md} + Dir.glob("{lib,exe}/**/*") | |||
There was a problem hiding this comment.
Sorry, for another request, but could you add the vmodl.db file in there as well. It's needed for rbvmomi to work.
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gem artifact is not the ideal place to ship examples, contributing
docs, a rake file and various hidden files. This will greatly reduce the
size of the installed gem artifact and speed up installs on systems with
malware scanners. This drops the compressed gem size from 221k to 47k.
Signed-off-by: Tim Smith tsmith@chef.io