Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Only ship the necessary libs in the gem artifact #148

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Only ship the necessary libs in the gem artifact #148

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c25438
Only ship the necessary libs in the gem artifact
tas50 Dec 18, 2018
d4e1c3b
Fix the path to the executables in the gemspec
tas50 Dec 18, 2018
c720cac
Add back vmodl.db
tas50 Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ language: ruby
rvm:
- 1.8.7
- 1.9.3
- 2.2.6
- 2.3.3
- 2.4.0
- 2.2.10
- 2.3.8
- 2.4.5
- 2.5.3
- jruby-1.7.26
- jruby-9.1.8.0
before_install:
Expand Down
2 changes: 1 addition & 1 deletion rbvmomi.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
spec.license = 'MIT'

spec.bindir = 'exe'
spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(/^test\//) }
spec.files = %w{LICENSE README.md} + Dir.glob("{lib,exec}/**/*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to put exe rather than exec in there, but that isn't really needed as you'll never require it and it's pulled into the gem through the spec.executables line below. What is needed, however, is the vmodl.db file in the root of the repository. Other than that, I think this looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Nice catch. I pushed a few for the right path.

spec.executables << 'rbvmomish'

spec.add_runtime_dependency('builder', '~> 3.0')
Expand Down