Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Adding support for SLES. #23

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Adding support for SLES. #23

merged 3 commits into from
Feb 2, 2018

Conversation

pshahzeb
Copy link
Contributor

@pshahzeb pshahzeb commented Feb 1, 2018

  1. Adding support for SLES.
  2. Updating prereq to indicate VM version required

Tested the HTML version of documents locally.

Updating prereq to indicate VM version required
@@ -35,6 +36,7 @@ Following table summarizes key features introduced in vSphere Cloud Provider in
- With kuberneters version 1.9.x if user wants to use multiple vCenters then vSAN storage can not be used. vSAN is limited to one cluster in one vCenter deployment.
* vCenter user with required set of privileges.
* VMware Tools needs to be installed on the guest operating system on each Node VM. Please refer this [link](https://docs.vmware.com/en/VMware-vSphere/6.5/com.vmware.vsphere.html.hostclient.doc/GUID-ED3ECA21-5763-4919-8947-A819A17980FB.html) for instruction on installing VMware tools.
* Virtual Hardware Version (VM version) 11 is required for VMs serving as Container Hosts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend explicitly calling out what the hardware version should not be, to avoid any interpretation like- 11 or higher.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say - "Node VMs should have Compatibility "ESXi 6.0 and later (VM version 11)".
We have not tested with any other VM compatibility yet.

Copy link
Contributor Author

@pshahzeb pshahzeb Feb 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyenpatel ESXi 6.0 and later implies ESX 6.5 too which by default comes with VM version 13. I think we can clearly only Virtual Hardware Version (VM version)
@prashima we have not tested VM version below 11 too. Anything higher than 11 isn't compatible. So I think we should particularly call out only version 11 . We need further testing to specify if anything below/above 11 is supported as well.

@@ -35,6 +36,7 @@ Following table summarizes key features introduced in vSphere Cloud Provider in
- With kuberneters version 1.9.x if user wants to use multiple vCenters then vSAN storage can not be used. vSAN is limited to one cluster in one vCenter deployment.
* vCenter user with required set of privileges.
* VMware Tools needs to be installed on the guest operating system on each Node VM. Please refer this [link](https://docs.vmware.com/en/VMware-vSphere/6.5/com.vmware.vsphere.html.hostclient.doc/GUID-ED3ECA21-5763-4919-8947-A819A17980FB.html) for instruction on installing VMware tools.
* Virtual Hardware Version (VM version) 11 is required for VMs serving as Container Hosts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we reword as follows - Virtual Hardware Version (VM version) 11 & onwards is required for VMs serving as Container Hosts.

Once @divyenpatel files a tracker issue for Virtual Hardware Version 13 compatibility I suggest updating the known issues section to reflect that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tusharnt issue for Version 13 compatibility is tracked at - vmware-archive/kubernetes-archived#450

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtual Hardware Version (VM version) 11 & onwards gives wrong message.
Virtual Hardware Version (VM version) 11 only works and tested.

Copy link
Contributor

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@@ -22,3 +22,6 @@ This section lists the major known issues with Kubernetes vSphere Cloud Provider
## vCenter Port other than 443
* For Kubernetes 1.6 and 1.7 releases (except Release v1.7.3 and onwards, Release v1.6.8 and onwards) vCenter Port other than 443 is not supported.

## Validation with Virtual Hardware version (VM version) 13
* Validation of VCP against Container Hosts running on VM version 13 is ongoing. [Link](https://github.com/vmware/kubernetes/issues/450)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container Hosts running on VM version 13 -> Container Hosts using Virtual Hardware version 13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in latest commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants