This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
Adding support for SLES. #23
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ Following table summarizes key features introduced in vSphere Cloud Provider in | |
| - CoreOs - v4.11.2 | ||
| - Centos - v7.3 | ||
| - RHEL OS - v7.4 | ||
| - SLES - v12 SP3 | ||
|
|
||
| * vSphere setup to deploy the Kubernetes cluster. | ||
| - For Kubernetes version 1.9.x and above: vSphere Cloud Provider supports Kubernetes cluster spanning across multiple vCenters. | ||
|
|
@@ -35,6 +36,7 @@ Following table summarizes key features introduced in vSphere Cloud Provider in | |
| - With kuberneters version 1.9.x if user wants to use multiple vCenters then vSAN storage can not be used. vSAN is limited to one cluster in one vCenter deployment. | ||
| * vCenter user with required set of privileges. | ||
| * VMware Tools needs to be installed on the guest operating system on each Node VM. Please refer this [link](https://docs.vmware.com/en/VMware-vSphere/6.5/com.vmware.vsphere.html.hostclient.doc/GUID-ED3ECA21-5763-4919-8947-A819A17980FB.html) for instruction on installing VMware tools. | ||
| * Virtual Hardware Version (VM version) 11 is required for VMs serving as Container Hosts. | ||
|
There was a problem hiding this comment. I suggest we reword as follows - Virtual Hardware Version (VM version) 11 & onwards is required for VMs serving as Container Hosts. Once @divyenpatel files a tracker issue for Virtual Hardware Version 13 compatibility I suggest updating the known issues section to reflect that. There was a problem hiding this comment. @tusharnt issue for There was a problem hiding this comment. Virtual Hardware Version (VM version) 11 & onwards gives wrong message. |
||
| * Node VM name requirements needed only until Kuberneters version 1.8.x. | ||
| - VM names can not begin with numbers. | ||
| - VM names can not have capital letters, any special characters except `.` and `-`. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend explicitly calling out what the hardware version should not be, to avoid any interpretation like- 11 or higher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say - "Node VMs should have Compatibility "ESXi 6.0 and later (VM version 11)".
We have not tested with any other VM compatibility yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divyenpatel
ESXi 6.0 and laterimplies ESX 6.5 too which by default comes with VM version 13. I think we can clearly onlyVirtual Hardware Version (VM version)@prashima we have not tested VM version below 11 too. Anything higher than 11 isn't compatible. So I think we should particularly call out only version 11 . We need further testing to specify if anything below/above 11 is supported as well.