Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts more cross-platform #170

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

idoru
Copy link
Contributor

@idoru idoru commented Sep 27, 2021

In particular, should work on Mac OS now.

Release date is now calculated at UTC for consistency. This conveniently avoids issues with supporting ISO8601 date format timezone.

[#168]

hack/release.sh Outdated Show resolved Hide resolved
Release date calcuated at UTC for consistency and also conveniently avoids issues with supporting ISO8601 date format timezone

[#168]
@idoru idoru force-pushed the 168-release-sh-cross-platform-fixes branch from 638bd3e to 00da102 Compare September 28, 2021 00:32
@netlify
Copy link

netlify bot commented Sep 28, 2021

✔️ Deploy Preview for elated-stonebraker-105904 canceled.

🔨 Explore the source changes: 00da102

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/615262a2c62b8e0008410053

Copy link
Contributor

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😁

@cirocosta cirocosta merged commit 738b777 into main Sep 28, 2021
@cirocosta cirocosta deleted the 168-release-sh-cross-platform-fixes branch September 28, 2021 11:43
@cirocosta cirocosta mentioned this pull request Sep 28, 2021
@cirocosta cirocosta linked an issue Sep 28, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RELEASE_DATE in release.sh
2 participants