Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify config #172

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

jonasrosland
Copy link
Contributor

This will add a netlify.toml configuration file to specify versions and build commands, and make a temporary fix for the site so we can see it deployed properly.

Signed-off-by: Jonas Rosland jrosland@vmware.com

Signed-off-by: Jonas Rosland <jrosland@vmware.com>
@netlify
Copy link

netlify bot commented Sep 28, 2021

✔️ Deploy Preview for elated-stonebraker-105904 ready!

🔨 Explore the source changes: 315025f

🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/61525eface10a3000813a0e8

😎 Browse the preview: https://deploy-preview-172--elated-stonebraker-105904.netlify.app

@cirocosta
Copy link
Contributor

cirocosta commented Sep 28, 2021

nice, @jonasrosland 😁

looking at #170 (comment), it makes me wonder if we should be building on any changes - is there a way of configuring the auto-build so that it's only for changes under ./site? (or .. maybe we got a build because it's the first run of it?)

also, I noticed that the endpoint is reachable without any auth - is that fine? or something we should configure (given that this repo is still private)? this is one of the acceptance criteria defined in #159

thank you!

@cirocosta cirocosta requested a review from DanieldeR September 28, 2021 11:47
@cirocosta cirocosta linked an issue Sep 28, 2021 that may be closed by this pull request
@jonasrosland
Copy link
Contributor Author

Site has been locked down with a password, shared in Slack. Right now Netlify builds on each run (only takes a minute), but we can change the notification behavior for sure.

@squeedee squeedee merged commit 5754fbf into vmware-tanzu:main Sep 28, 2021
@squeedee squeedee deleted the netlify-config branch September 28, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy the OSS Docs
3 participants