bump kapp-controller (0.25.0 --> 0.27.0) #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for elated-stonebraker-105904 ready! 🔨 Explore the source changes: 891add0 🔍 Inspect the deploy log: https://app.netlify.com/sites/elated-stonebraker-105904/deploys/615dc7acceff3e000860602f 😎 Browse the preview: https://deploy-preview-207--elated-stonebraker-105904.netlify.app |
cirocosta
commented
Oct 6, 2021
| @@ -98,8 +98,10 @@ kubectl create clusterrolebinding default-admin \ | |||
| --clusterrole=cluster-admin \ | |||
| --serviceaccount=default:default | |||
|
|
|||
| KAPP_CONTROLLER_VERSION=0.27.0 | |||
There was a problem hiding this comment.
imo the biggest benefit of this pattern is that it then becomes really easy to find everywhere where the version of a particular dependency exists:
ag KAPP_CONTROLLER_VERSIONand then boom, you found all the places:
site/content/docs/v0.0.6/install.md
222:KAPP_CONTROLLER_VERSION=0.27.0
225: -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml
site/content/docs/install.md
222:KAPP_CONTROLLER_VERSION=0.27.0
225: -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml
hack/setup.sh
34:readonly KAPP_CONTROLLER_VERSION=0.27.0
224: -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml |
examples/source-to-knative-service/README.md
101:KAPP_CONTROLLER_VERSION=0.27.0
104: -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml
changeset: https://github.com/vmware-tanzu/carvel-kapp-controller/releases/tag/v0.26.0 - Bump kapp to v0.42.0 which allowed to further speed up reconciliation of package repositories https://github.com/vmware-tanzu/carvel-kapp-controller/releases/tag/v0.27.0 - Set default syncPeriod to 10min for PackageRepository and PackageInstall CRs - Previously it was 30s for PackageInstalls and 5min for PackageRepositories - Updated k8s.io/api-server to eliminate package repository reconciliation problems on GKE (#377) - Bump kapp to v0.41.0 which allowed to speed up reconciliation of package repositories Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
cirocosta
force-pushed
the
kapp-ctrl-bump
branch
from
d08dc48 to
891add0
Compare
emmjohnson
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changeset:
Signed-off-by: Ciro S. Costa ciroscosta@vmware.com