Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kapp-controller (0.25.0 --> 0.27.0) #207

Merged
merged 1 commit into from
Oct 12, 2021
Merged

bump kapp-controller (0.25.0 --> 0.27.0) #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/source-to-knative-service/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ kubectl create clusterrolebinding default-admin \
--clusterrole=cluster-admin \
--serviceaccount=default:default

KAPP_CONTROLLER_VERSION=0.27.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo the biggest benefit of this pattern is that it then becomes really easy to find everywhere where the version of a particular dependency exists:

ag KAPP_CONTROLLER_VERSION

and then boom, you found all the places:

site/content/docs/v0.0.6/install.md
222:KAPP_CONTROLLER_VERSION=0.27.0
225:  -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml

site/content/docs/install.md
222:KAPP_CONTROLLER_VERSION=0.27.0
225:  -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml

hack/setup.sh
34:readonly KAPP_CONTROLLER_VERSION=0.27.0
224:                -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml |

examples/source-to-knative-service/README.md
101:KAPP_CONTROLLER_VERSION=0.27.0
104:    -f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml


kapp deploy --yes -a kapp-controller \
-f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v0.25.0/release.yml
-f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml
```

- [knative-serving], for being the runtime of the application we want to deploy.
Expand Down
2 changes: 1 addition & 1 deletion hack/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ readonly REGISTRY_CONTAINER_NAME=cartographer-registry
readonly KUBERNETES_CONTAINER_NAME=cartographer-control-plane

readonly CERT_MANAGER_VERSION=1.5.3
readonly KAPP_CONTROLLER_VERSION=0.25.0
readonly KAPP_CONTROLLER_VERSION=0.27.0
readonly KNATIVE_SERVING_VERSION=0.25.0
readonly KPACK_VERSION=0.3.1
readonly SECRETGEN_CONTROLLER_VERSION=0.5.0
Expand Down
4 changes: 3 additions & 1 deletion site/content/docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,10 @@ In case you don't (i.e., you see _"packageinstalls.packaging.carvel.dev" not
found_), proceed with installing it.

```bash
KAPP_CONTROLLER_VERSION=0.27.0

kapp deploy --yes -a kapp-controller \
-f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v0.25.0/release.yml
-f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml
```
```console
Target cluster 'https://127.0.0.1:39993' (nodes: cartographer-control-plane)
Expand Down
4 changes: 3 additions & 1 deletion site/content/docs/v0.0.6/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,10 @@ In case you don't (i.e., you see _"packageinstalls.packaging.carvel.dev" not
found_), proceed with installing it.

```bash
KAPP_CONTROLLER_VERSION=0.27.0

kapp deploy --yes -a kapp-controller \
-f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v0.25.0/release.yml
-f https://github.com/vmware-tanzu/carvel-kapp-controller/releases/download/v$KAPP_CONTROLLER_VERSION/release.yml
```
```console
Target cluster 'https://127.0.0.1:39993' (nodes: cartographer-control-plane)
Expand Down