config: add app.kubernetes.io/component label
#794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
following the best practices when it comes to labelling objects (see [1]), by making use of the recommended `app.kubernetes.io/component`, we're able to clearly identify those objects that are part of cartographer (useful for any tool that might want to do some form of matching against anything cartographer-related, e.g., getting rid of all of them based on matching on such label). the approach I took here is to make use of ytt overlays in order to add the label to all components _except_ the Namespace. [1]: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
✅ Deploy Preview for elated-stonebraker-105904 canceled.
|
|
cc @scothis |
This was referenced Apr 6, 2022
Merged
scothis
reviewed
Apr 6, 2022
emmjohnson
reviewed
Apr 6, 2022
Co-authored-by: Scott Andrews <andrewssc@vmware.com>
Co-authored-by: Emily Johnson <51918476+emmjohnson@users.noreply.github.com>
scothis
approved these changes
Apr 6, 2022
emmjohnson
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
app.kubernetes.io/componentlabel to identify objects as being all part of cartographerfollowing the best practices when it comes to labelling objects (see
1), by making use of the recommended
app.kubernetes.io/component,we're able to clearly identify those objects that are part of
cartographer (useful for any tool that might want to do some form of
matching against anything cartographer-related, e.g., getting rid of all
of them based on matching on such label).
the approach I took here is to make use of ytt overlays in order to add
the label to all components except the Namespace.
Release Note
app.kubernetes.io/component: cartographer.carto.runlabel to all cartographer objects (except namespace).PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits