Skip to content
Makefile CI

Pass context.Context directly rather than passing its pointer in function parameters #2701

Sign in to view logs

Pass context.Context directly rather than passing its pointer in function parameters

Pass context.Context directly rather than passing its pointer in function parameters #2701

Triggered via pull request August 21, 2024 14:15
@wenqiqwenqiq
opened #714
wenqiq:topic/wenqi/code-improve
Status Failure
Total duration 2m 21s
Artifacts –

makefile.yml

on: pull_request
build
2m 12s
build
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 2 warnings
build: cmd/main.go#L28
could not import github.com/vmware-tanzu/nsx-operator/pkg/controllers/networkinfo (-: # github.com/vmware-tanzu/nsx-operator/pkg/controllers/networkinfo
build: pkg/controllers/networkinfo/networkinfo_controller.go#L243
cannot use &ctx (value of type *context.Context) as context.Context value in argument to deleteFail: *context.Context does not implement context.Context (type *context.Context is pointer to interface, not interface)) (typecheck)
build: pkg/controllers/networkinfo/networkinfo_controller.go#L243
cannot use &ctx (value of type *context.Context) as context.Context value in argument to deleteFail: *context.Context does not implement context.Context (type *context.Context is pointer to interface, not interface) (typecheck)
build
Process completed with exit code 2.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-go@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/