[VPC] Add NSX LBS path to VPCInfo and use LB options in NsxConfig #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gran-vmv
force-pushed
the
lbvpc-crd
branch
2 times, most recently
from
20ea6fa
to
6af1cb3
Compare
gran-vmv
force-pushed
the
lbvpc-crd
branch
3 times, most recently
from
6522fff
to
51e1b38
Compare
zhengxiexie
reviewed
Jul 9, 2024
| @@ -60,6 +60,8 @@ type VPCInfo struct { | |||
| Name string `json:"name"` | |||
| // AVISESubnetPath is the NSX Policy Path for the AVI SE Subnet. | |||
| AVISESubnetPath string `json:"lbSubnetPath,omitempty"` | |||
| // NSXLBSPath is the NSX Policy path for the NSX LB Service path. | |||
There was a problem hiding this comment.
Hi, pls refer #629 (comment)
There was a problem hiding this comment.
Checked this comment and we already run make manifests/make generated and included the changes in this PR.
|
BTW, could you update build/yaml/samples/nsx_v1alpha1_vpcnetworkconfigurations.yml ? |
There is no |
Signed-off-by: gran <gran@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.