[CRD] Add field vpc in VPCNetworkConfiguration #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantingl
reviewed
Jul 8, 2024
|
/e2e |
wenyingd
changed the title
zhengxiexie
reviewed
Jul 9, 2024
lxiaopei
reviewed
Jul 9, 2024
lxiaopei
reviewed
Jul 9, 2024
pkg/apis/nsx.vmware.com/v1alpha1/vpcnetworkconfiguration_types.go
Outdated
Show resolved
Hide resolved
|
BTW, could you update build/yaml/samples/nsx_v1alpha1_vpcnetworkconfigurations.yml ? |
lxiaopei
reviewed
Jul 9, 2024
wenyingd
force-pushed
the
precreate_vpc
branch
2 times, most recently
from
4fce381
to
0ade6df
Compare
|
Having offline sync with @lxiaopei, adding a separate VPCNetworkConfiguration CR sample focusing on pre-created VPC scenario makes it less confusion, updated accordingly. |
wenyingd
force-pushed
the
precreate_vpc
branch
2 times, most recently
from
5fac3d9
to
fbd8239
Compare
|
/e2e |
lxiaopei
reviewed
Jul 11, 2024
lxiaopei
reviewed
Jul 11, 2024
lxiaopei
approved these changes
Jul 11, 2024
|
/e2e |
dantingl
approved these changes
Jul 12, 2024
wenyingd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.