Use label to select Velero deployment in plugin cmd #3447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F. Gold <fgold@vmware.com>
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
jenting,
nrb and
zubron
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
codegold79
force-pushed
the
3088-Use-Label-Selector-to-Add-Remove-Plugins
branch
from
692845a
to
0a4cc32
Compare
4 tasks
jenting
reviewed
Feb 10, 2021
Signed-off-by: F. Gold <fgold@vmware.com>
jenting
previously approved these changes
Feb 10, 2021
nrb
suggested changes
Feb 10, 2021
Signed-off-by: F. Gold <fgold@vmware.com>
jenting
approved these changes
Feb 11, 2021
nrb
approved these changes
Feb 11, 2021
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
* Use label to select Velero deployment in plugin cmd Signed-off-by: F. Gold <fgold@vmware.com> * Move veleroLabel constant closer to usage Signed-off-by: F. Gold <fgold@vmware.com> * Add changelog Signed-off-by: F. Gold <fgold@vmware.com> * Remove year from copyright in new file Signed-off-by: F. Gold <fgold@vmware.com> * Export and use install.Labels() function Signed-off-by: F. Gold <fgold@vmware.com>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
* Use label to select Velero deployment in plugin cmd Signed-off-by: F. Gold <fgold@vmware.com> * Move veleroLabel constant closer to usage Signed-off-by: F. Gold <fgold@vmware.com> * Add changelog Signed-off-by: F. Gold <fgold@vmware.com> * Remove year from copyright in new file Signed-off-by: F. Gold <fgold@vmware.com> * Export and use install.Labels() function Signed-off-by: F. Gold <fgold@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
* Use label to select Velero deployment in plugin cmd Signed-off-by: F. Gold <fgold@vmware.com> * Move veleroLabel constant closer to usage Signed-off-by: F. Gold <fgold@vmware.com> * Add changelog Signed-off-by: F. Gold <fgold@vmware.com> * Remove year from copyright in new file Signed-off-by: F. Gold <fgold@vmware.com> * Export and use install.Labels() function Signed-off-by: F. Gold <fgold@vmware.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3088.
Modfied pkg/cmd/cli/plugin package files add.go and get.go. Instead of finding a Velero deployment using the name, "velero", used a label, "component=velero".
The Velero Helm chart will be modified to include the "component=velero" label. See vmware-tanzu/helm-chart PR215.
Signed-off-by: F. Gold fgold@vmware.com