Add HTTP User-Agent header to all requests in SDK #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbauzys
approved these changes
Oct 5, 2020
|
dataclouder
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default HTTP
User-Agentheader with valuego-vcloud-director. It also adds the capability to customize (or disable) this value by usingWithHttpUserAgent()configuration option forNewVCDClientfunction.Note. Testing to ensure that all outgoing requests contain HTTP header is not trivial therefore this library extends
utilpackage with an additional flagPanicEmptyUserAgentwhich would cause panic inProcessRequestOutputfunction which is hopefully logging gateway to all current and future HTTP requests.func (vcd *TestVCD) SetUpSuite(check *C)is configured to include verification of it by default.Tests did pass which means (as per above note) that all logged HTTP calls have the header set.