Add User-Agent header to all API calls #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbauzys
reviewed
Oct 5, 2020
lvirbalas
reviewed
Oct 5, 2020
lvirbalas
approved these changes
Oct 5, 2020
It was a change done previously by @dataclouder in go-vcloud-director (vmware/go-vcloud-director#327) however we have not included that note in terraform-provider-vcd changelog and I think it is quite important. |
Let's not forget to run full test before release then for this specific version |
vbauzys
approved these changes
Oct 6, 2020
dataclouder
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use new govcd functionality to send HTTP User-Agent (introduced in vmware/go-vcloud-director#336).
The sample header
User-Agent: [terraform-provider-vcd/v2.9.0-16-gb1cfc7b5 (darwin/amd64; isProvider:true)](for stable version -User-Agent: [terraform-provider-vcd/v2.9.0 (darwin/amd64; isProvider:true)])Version is to be output of
git describe. OS is described by GOOS and GOARCH.isProvideris set ifSysorg==System.git describeis injected in during build time usinggo build -ldflagsflag inside Makefile.Note If user uses
go installtheBuildVersionvariable will remain default ("unset")In addition this PR bumps Travis config to use Go 1.15 for testing as this is the version used now.