Api bump from v33.0 to v35.0 #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 7, 2022 13:03
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
added 2 commits
February 8, 2022 14:58
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
mikeletux
requested review from
dataclouder,
Didainius,
vbauzys,
lvirbalas and
adambarreiro
vbauzys
approved these changes
Feb 9, 2022
adambarreiro
approved these changes
Feb 9, 2022
lvirbalas
approved these changes
Feb 15, 2022
|
⚠⚠⚠ Do not merge this yet as I still need to make the changes to bump this from v34.0 to v35.0 |
dataclouder
reviewed
Feb 18, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
added 8 commits
February 22, 2022 16:35
Improve Vdc.UpdateOpenApiOrgVdcNetworkDhcp method to allow setting OpenApiOrgVdcNetworkDhcp.LeaseTime and OpenApiOrgVdcNetworkDhcp.Mode to default values in case the passed struct doesn't have them set Signed-off-by: Miguel Sama <msama@vmware.com>
…cd.ComposeVApp. Replace vcd.createTestVapp in favor of deployVappForTest when setting up the test suite. Signed-off-by: Miguel Sama <msama@vmware.com>
…ed anymore Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
dataclouder
approved these changes
Feb 24, 2022
lvirbalas
reviewed
Feb 28, 2022
added 2 commits
March 1, 2022 11:34
…bump-v34 Signed-off-by: Miguel Sama <msama@vmware.com>
Signed-off-by: Miguel Sama <msama@vmware.com>
lvirbalas
reviewed
Mar 1, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
reviewed
Mar 1, 2022
adambarreiro
approved these changes
Mar 2, 2022
Signed-off-by: Miguel Sama <msama@vmware.com>
Didainius
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short description
Bump SDK API compatible version from v33.0 to v35.0
Detailed description
Updated the API version that the SDK is compatible with from v33.0 (min VCD versions 10.0) to v35.0 (min VCD version 10.2).
This bump needs to be done as we are not going to officially support VCD 10.1 anymore.
Also, added the function
deployVappForTestthat creates a sample vApp for testing, to replace the old onecreateVappForTestthat was using the deprecated methodvdc.ComposeVApp. This was done because issues were found while testing the API bumb to v34.0.Replaced all
createVappForTestcalls done in test bydeployVappForTest.Removed function createVappForTest`.