Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Provider VDCs read functions and upgrade Compute Policies version #502

Merged
merged 17 commits into from
Sep 1, 2022
Merged

Add support for Provider VDCs read functions and upgrade Compute Policies version #502

merged 17 commits into from
Sep 1, 2022

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Aug 25, 2022 •
edited
Loading

Description

This PR sets the foundations required for vmware/terraform-provider-vcd#904:

  • Adds retrieval support for Provider VDCs, both "regular" and the "extension". The extension is a superset of attributes not present in "regular" Provider VDC endpoints. In VCD UI, both endpoints are used.
  • Updates VDC Compute Policies retrieval methods AdminVdc.GetAllAssignedVdcComputePolicies and Org.GetAllVdcComputePolicies from OpenAPI v1.0.0 to v2.0.0, this version supports more filtering options like isVgpuPolicy
  • Adds some utility private functions and fixes some typos.

Init
ea64aca 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro changed the title Init Add support for VM Placement Policies Aug 25, 2022
abarreiro added 10 commits August 25, 2022 12:17
Remove OpenAPI endpoint
b4a34a2 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Add Provider VDC types
3eb87b1 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Finish provider functions
a20f246 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Fixes
532b8f5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
fmt
e9d2fb3 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Fix
d7cf451 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Complete pvdc
dbee8c5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Fix bug with capacity
1d315aa 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Revert openapi endpoint removal
f8e46fa 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Changelog
3a8b73b 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro changed the title Add support for VM Placement Policies Add support for Provider VDCs and upgrade Compute Policies version Aug 29, 2022
Changelog
537f89e 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro self-assigned this Aug 29, 2022
abarreiro added 2 commits August 29, 2022 11:20
Fix test tags
960437d 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Merge branch 'main' of https://github.com/adambarreiro/go-vcloud-dire…
56b6b59 
…ctor into add-placement-policy-support

Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro marked this pull request as ready for review August 29, 2022 09:26
@adambarreiro adambarreiro mentioned this pull request Aug 29, 2022
Merged
6 tasks
Didainius
Didainius reviewed Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great - just a few queries before approval

types/v56/constants.go Show resolved Hide resolved
types/v56/types.go Show resolved Hide resolved
govcd/provider_vdc.go Outdated Show resolved Hide resolved
types/v56/types.go Outdated Show resolved Hide resolved
abarreiro added 3 commits August 29, 2022 14:43
Make constructors private
1982f98 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Added omitempty to Total in ProviderVdcCapacity
e8dd6c8 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Remove Vdcs from struct
364b278 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Copy link
Collaborator Author

I removed Vdcs slice from ProviderVdc struct as I confirmed that this field is never populated nor used.

@adambarreiro adambarreiro changed the title Add support for Provider VDCs and upgrade Compute Policies version Add support for Provider VDCs read functions and upgrade Compute Policies version Aug 30, 2022
@adambarreiro adambarreiro mentioned this pull request Aug 30, 2022
Merged
lvirbalas
lvirbalas approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adambarreiro adambarreiro merged commit 6176f3e into vmware:main Sep 1, 2022
@adambarreiro adambarreiro deleted the add-placement-policy-support branch September 1, 2022 07:56
@adambarreiro adambarreiro mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@adambarreiro adambarreiro

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adambarreiro @lvirbalas @Didainius @vmwclabot