New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VM Group and Logical VM Group support to facilitate VM Placement Policy creation; Update Compute Policies to v2.0.0 #504

Merged

adambarreiro merged 52 commits into vmware:main from adambarreiro:extend-placement-policy-support

Sep 23, 2022

Collaborator

adambarreiro commented Aug 30, 2022 •

edited

Loading

This PR builds on top of #502.

Description

Same as #502, this PR aims to serve as the foundation for vmware/terraform-provider-vcd#904.
This PR contains the required changes to be able to create the vcd_vm_placement_policy resource to be able to test it.

As vcd_vm_placement_policy requires to handle VM Groups and Logical VM Groups in VCD, there are additions of some functions for that purpose.

It also updates Compute Policies OpenAPI support from v1.0.0 to v2.0.0, marking v1.0.0 as deprecated and leaving it untouched, while creating a new set of functions for the new version to avoid breaking compatibility. This change was done to support more filtering options of the v2.0.0 endpoint and prepare for the future.

Other changes

Description field in VdcComputePolicy is now a pointer and is not omitted when empty. This is because we need to send an explicit nil/null value to the VCD API to be able to declare empty descriptions. Otherwise, if the parameter is omitted, VCD puts a default description.

Testing

Tests require a new field in govcd_test_config.yaml:

vcd:
    ...
    nsxt_provider_vdc:
      ...
      placementPolicyVmGroup: testVmGroup

abarreiro added 18 commits

August 25, 2022 12:13


          Init

ea64aca

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Remove OpenAPI endpoint

b4a34a2

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Add Provider VDC types

3eb87b1

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Finish provider functions

a20f246

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Fixes

532b8f5

Signed-off-by: abarreiro <abarreiro@vmware.com>

fmt

e9d2fb3

Signed-off-by: abarreiro <abarreiro@vmware.com>

Fix

d7cf451

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Complete pvdc

dbee8c5

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Fix bug with capacity

1d315aa

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Revert openapi endpoint removal

f8e46fa

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Changelog

3a8b73b

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Changelog

537f89e

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Fix test tags

960437d

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Merge branch 'main' of https://github.com/adambarreiro/go-vcloud-dire…

56b6b59

…ctor into add-placement-policy-support

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Make constructors private

1982f98

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Added omitempty to Total in ProviderVdcCapacity

e8dd6c8

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Remove Vdcs from struct

364b278

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Add VM Logical Groups support

54d8de6

Signed-off-by: abarreiro <abarreiro@vmware.com>

vmwclabot added the cla-not-required label

abarreiro added 2 commits

August 30, 2022 16:15


          Add changelog

62fe361

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Fix tests

a0c2de0

Signed-off-by: abarreiro <abarreiro@vmware.com>

adambarreiro mentioned this pull request

Add Provider VDC and VM Group data sources, VM Placement policies resource+data source and support for VM Placement policies in VDCs vmware/terraform-provider-vcd#904

Merged

6 tasks


          Merge branch 'main' of https://github.com/adambarreiro/go-vcloud-dire…

c254016

…ctor into extend-placement-policy-support

Signed-off-by: abarreiro <abarreiro@vmware.com>

adambarreiro self-assigned this

abarreiro added 2 commits

September 1, 2022 09:57


          Merge branch 'main' of https://github.com/adambarreiro/go-vcloud-dire…

1c23890

…ctor into extend-placement-policy-support

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Update changelog

5dea389

Signed-off-by: abarreiro <abarreiro@vmware.com>

adambarreiro changed the title ~~Extend placement policy support~~ Add VM Group and Logical VM Group support to facilitate VM Placement Policy creation

adambarreiro marked this pull request as ready for review

September 1, 2022 08:02

adambarreiro requested review from lvirbalas and Didainius as code owners

September 1, 2022 08:02

lvirbalas requested a review from dataclouder

September 2, 2022 15:31

adambarreiro commented

View reviewed changes

types/v56/openapi.go Show resolved Hide resolved

adambarreiro changed the title ~~Add VM Group and Logical VM Group support to facilitate VM Placement Policy creation~~ Add VM Group and Logical VM Group support to facilitate VM Placement Policy creation; Update Compute Policies to v2.0.0

lvirbalas reviewed

View reviewed changes

govcd/vdccomputepolicy_v2.go Show resolved Hide resolved

govcd/vdccomputepolicy_v2.go Outdated Show resolved Hide resolved

govcd/vdccomputepolicy_v2.go Outdated Show resolved Hide resolved

govcd/vdccomputepolicy_v2_test.go Outdated Show resolved Hide resolved

abarreiro added 2 commits

September 5, 2022 16:39

fmt

ac02aaf

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Address comments

2a32cbb

Signed-off-by: abarreiro <abarreiro@vmware.com>

Didainius approved these changes

View reviewed changes

Collaborator

Didainius left a comment

Thanks - a few comments need addressing but approving ahead.

govcd/vm_groups.go Show resolved Hide resolved

types/v56/openapi.go Outdated Show resolved Hide resolved

govcd/vm_groups.go Outdated Show resolved Hide resolved

abarreiro added 2 commits

September 6, 2022 10:15


          Changed to pointer and non-omitempty field

0ecfb3d

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Config sample

1914a6d

Signed-off-by: abarreiro <abarreiro@vmware.com>

adambarreiro marked this pull request as ready for review

September 6, 2022 08:16

abarreiro added 4 commits

September 6, 2022 12:16


          Fix resourcepool parameter

d78862c

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Address suggestion

7edd9b1

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Address suggestion

75323f0

Signed-off-by: abarreiro <abarreiro@vmware.com>

fmt

20ad037

Signed-off-by: abarreiro <abarreiro@vmware.com>

lvirbalas approved these changes

View reviewed changes

abarreiro added 3 commits

September 8, 2022 09:58


          Amend placementPolicyVmGroup config

f8e808f

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Amend placementPolicyVmGroup config

f580cae

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Amend placementPolicyVmGroup config

Signed-off-by: abarreiro <abarreiro@vmware.com>

dataclouder suggested changes

View reviewed changes

Contributor

dataclouder left a comment

First pass. A few suggestions, in addition to the test result review

govcd/openapi_endpoints.go Outdated Show resolved Hide resolved

govcd/vdccomputepolicy_v2.go Show resolved Hide resolved

govcd/vdccomputepolicy_v2_test.go Show resolved Hide resolved

govcd/vdccomputepolicy_v2_test.go Outdated Show resolved Hide resolved

abarreiro added 4 commits

September 12, 2022 09:35


          Fix cleanup error

316e37e

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Fix problems with tests

ea7ecb2

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Add constant

8122bc8

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Remove confusing comment

6e27d54

Signed-off-by: abarreiro <abarreiro@vmware.com>

dataclouder approved these changes

View reviewed changes

abarreiro added 2 commits

September 21, 2022 14:38


          Merge branch 'main' of https://github.com/adambarreiro/go-vcloud-dire…

462b21c

…ctor into extend-placement-policy-support

Signed-off-by: abarreiro <abarreiro@vmware.com>


          Add Deprecated note to VdcComputePolicy

68117f5

Signed-off-by: abarreiro <abarreiro@vmware.com>

adambarreiro merged commit 7fcefa6 into vmware:main

adambarreiro deleted the extend-placement-policy-support branch

September 23, 2022 11:27

adambarreiro mentioned this pull request

Improve error message when creating a duplicate VM Placement Policy #507

Merged

adambarreiro mentioned this pull request

Fix multiple resource pools issue when fetching VM Groups #530

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-not-required