-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CatalogItem metadata support for vcd_catalog_item #851
Add CatalogItem metadata support for vcd_catalog_item #851
Conversation
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Tested manually and works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few requests, but approving in advance. Don't hesitate to resolve my comments when ready to merge this time.
@adambarreiro, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@adambarreiro, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: abarreiro <abarreiro@vmware.com>
18553b5
to
2b3a65c
Compare
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Description
This PR adds the capability of including metadata in the
vcd_catalog_item
resource that belongs to the CatalogItem itself, as right now themetadata
attribute belongs to the associated vApp template. The new attribute for this is called catalog_item_metadata.The data source has been also updated to fetch the CatalogItem metadata into that attribute.
Documentation and log messages have been updated accordingly.
The changes somehow relate to the issue #502