Refactor metadata handling #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
May 12, 2022 09:42
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 2 commits
May 19, 2022 09:23
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 3 commits
May 19, 2022 12:54
added 2 commits
May 25, 2022 15:59
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
approved these changes
May 31, 2022
Signed-off-by: abarreiro <abarreiro@vmware.com>
|
Bumped again SDK to 2.1.7.0 |
lvirbalas
reviewed
Jun 2, 2022
mikeletux
approved these changes
Jun 2, 2022
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
approved these changes
Jun 2, 2022
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains #851, merge that one first.
Description
The idea comes from this suggestion made by @vbauzysvmware in #851.
The outcome is a cleaner code, with several duplications for
metadatahandling being removed and reduced to a single common place.The PR requires vmware/go-vcloud-director#473 as this one provides the new
MergeMetadatafunction that is now used by the generic function.Extra
Bumps SDK to v2.17.0 to avoid the mentioned bug when executing tests.
Testing
Tested on VCD 10.3.2, 10.3.0, 10.2.2