Add an option to change the default shell. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not object to this. Configuration in this particular area might be useful. The previous PR posited "The default shell should be bash" which was wrong. This one posits "The default shell should be configurable on image creation" which seems reasonable. I'm pretty sure the commit message is incorrect. |
meator
force-pushed
the
default_shell
branch
2 times, most recently
from
fc2b155
to
2c53fca
Compare
|
I've made the commit message clearer. |
This commit add a -S option that changes the default root shell of the iso. It also mentions the live.shell kernel option that changes the shell of the unprivileged user (anon).
classabbyamp
added
the
installer
0x5c
reviewed
Feb 20, 2023
Comment on lines
+78
to
+79
| -S <shell> Default shell of the root user (must be absolute path). | ||
| Set the live.shell kernel parameter to change the default shell of anon. |
There was a problem hiding this comment.
Since this PR was made, #267 was merged and added a -S argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to set the default shell of the
rootuser and documents thelive.shellkernel option.I know that a similar change has already been closed (#99). My change makes this more configurable and optional. And it documents the
live.shelloption that isn't documented anywhere else and is pretty useful.I'll understand if you close this, but I consider this helpful for people who are customizing their iso.