Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require explicitly listing enabled services #267

Closed
wants to merge 1 commit into from

Conversation

paper42
Copy link
Member

@paper42 paper42 commented Jul 11, 2022

Previously all services were enabled with some exceptions. That way some
services got enabled unintentionally when they were added somewhere in
the dependency tree.

This commit requires explicitly listing enabled services with the
exception of DEFAULT_SERVICE_LIST in mklive.sh - agetty-tty1-6, udevd.

difference from the generated images before this commit:

plain mklive:  -acpid -dhcpcd -sshd -uuidd
base:          -uuidd
enlightenment: -uuidd -acpid -rtkit
xfce:          -uuidd -acpid -rtkit
mate:          -uuidd -acpid -rtkit
cinnamon:      -uuidd -acpid -rtkit -colord
gnome:         -uuidd -acpid -rtkit -colord -bluetoothd -brltty
lxde:          -uuidd -rtkit
lxqt:          -uuidd -acpid -rtkit
kde:           -uuidd -acpid -bluetoothd -boltd -tcsd

All images should be tested to make sure the services that are now disabled were not required.

depends on #265 (merged)

@paper42 paper42 force-pushed the enable-services branch 2 times, most recently from f252898 to e2dce57 Compare July 11, 2022 23:25
@paper42
Copy link
Member Author

paper42 commented Jul 17, 2022

  • base
  • gnome (gdm now crashes a few times until it finally works probably because ibus is not starting fast enough)
  • kde
  • enlightenment
  • xfce
  • mate
  • cinnamon
  • lxde
  • lxqt

@leahneukirchen
Copy link
Member

Should we run acpid to shutdown on power button? or is that done differently these days?

@paper42
Copy link
Member Author

paper42 commented Jul 17, 2022

Should we run acpid to shutdown on power button? or is that done differently these days?

I still need to test that. All images built with build-x86-images.sh have either acpid or elogind which should handle this. Only a plain mklive run will now produce an image without acpid just because I wanted to only use elogind without acpid in some images.

This way, mklive generates a minimal bootable iso and users including build-x86-images.sh just add what they want to it. I think this is closer to its goal if I understand it correctly and also is much cleaner - we don't have to have two flags, one for enabling extra services/adding extra packages and one for disabling/removing, we can just add.

It wouldn't be nice if the power button didn't work without acpid, but I will have to test that on real hardware.

@paper42
Copy link
Member Author

paper42 commented Jul 27, 2022

I finished testing all the isos, so this should be ready for a review. acpid is required for shutdown with a power button, but this PR only removes it from plain mklive, not from the base iso.

cc @the-maldridge

@paper42 paper42 marked this pull request as ready for review July 27, 2022 21:10
@the-maldridge
Copy link
Member

Please fix conflicts and re-push.

Previously all services were enabled with some exceptions. That way some
services got enabled unintentionally when they were added somewhere in
the dependency tree.

This commit requires explicitly listing enabled services with the
exception of DEFAULT_SERVICE_LIST in mklive.sh - agetty-tty1-6, udevd.

difference from the generated images before this commit:
plain mklive:  -acpid -dhcpcd -sshd -uuidd
base:          -uuidd
enlightenment: -uuidd -acpid -rtkit
xfce:          -uuidd -acpid -rtkit
mate:          -uuidd -acpid -rtkit
cinnamon:      -uuidd -acpid -rtkit -colord
gnome:         -uuidd -acpid -rtkit -colord -bluetoothd -brltty
lxde:          -uuidd -rtkit
lxqt:          -uuidd -acpid -rtkit
kde:           -uuidd -acpid -bluetoothd -boltd -tcsd
@paper42
Copy link
Member Author

paper42 commented Sep 3, 2022

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants